From 5cdae1d0ba99364e8a1a586217d37ac42271417e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maxime=20Ch=C3=A9ramy?= Date: Sat, 28 May 2016 23:27:47 +0200 Subject: [PATCH 1/8] Add possibility to give a list of batteries instead of only one. --- widgets/bat.lua | 107 ++++++++++++++++++++++++++++-------------------- 1 file changed, 63 insertions(+), 44 deletions(-) diff --git a/widgets/bat.lua b/widgets/bat.lua index 43b7a5f..e1bc5d1 100644 --- a/widgets/bat.lua +++ b/widgets/bat.lua @@ -23,12 +23,12 @@ local setmetatable = setmetatable -- lain.widgets.bat local function worker(args) - local bat = {} - local args = args or {} - local timeout = args.timeout or 30 - local battery = args.battery or "BAT0" - local ac = args.ac or "AC0" - local notify = args.notify or "on" + local bat = {} + local args = args or {} + local timeout = args.timeout or 30 + local batteries = args.batteries or (args.battery and {args.battery}) or {"BAT0"} + local ac = args.ac or "AC0" + local notify = args.notify or "on" local settings = args.settings or function() end bat.widget = wibox.widget.textbox('') @@ -58,52 +58,71 @@ local function worker(args) watt = "N/A" } - local bstr = "/sys/class/power_supply/" .. battery - local astr = "/sys/class/power_supply/" .. ac - local present = first_line(bstr .. "/present") + local sum_rate_current = 0 + local sum_rate_voltage = 0 + local sum_rate_power = 0 + local sum_energy_now = 0 + local sum_energy_full = 0 + local sum_energy_percentage = 0 - if present == "1" - then - -- current_now(I)[uA], voltage_now(U)[uV], power_now(P)[uW] - local rate_current = tonumber(first_line(bstr .. "/current_now")) - local rate_voltage = tonumber(first_line(bstr .. "/voltage_now")) - local rate_power = tonumber(first_line(bstr .. "/power_now")) + for i, battery in ipairs(batteries) do + local bstr = "/sys/class/power_supply/" .. battery + local present = first_line(bstr .. "/present") - -- energy_now(P)[uWh], charge_now(I)[uAh] - local energy_now = tonumber(first_line(bstr .. "/energy_now") or - first_line(bstr .. "/charge_now")) - - -- energy_full(P)[uWh], charge_full(I)[uAh] - local energy_full = tonumber(first_line(bstr .. "/energy_full") or - first_line(bstr .. "/charge_full")) - - local energy_percentage = tonumber(first_line(bstr .. "/capacity")) or - math.floor((energy_now / energy_full) * 100) - - bat_now.status = first_line(bstr .. "/status") or "N/A" - bat_now.ac_status = first_line(astr .. "/online") or "N/A" - - -- update {perc,time,watt} iff rate > 0 and battery not full - if ((rate_current and rate_current > 0) or (rate_power and rate_power > 0)) - and bat_now.status ~= "N/A" and bat_now.status ~= "Full" + if present == "1" then - local rate_time = 0 - if bat_now.status == "Charging" then - rate_time = (energy_full - energy_now) / (rate_power or rate_current) - elseif bat_now.status == "Discharging" then - rate_time = energy_now / (rate_power or rate_current) + -- current_now(I)[uA], voltage_now(U)[uV], power_now(P)[uW] + local rate_current = tonumber(first_line(bstr .. "/current_now")) + local rate_voltage = tonumber(first_line(bstr .. "/voltage_now")) + local rate_power = tonumber(first_line(bstr .. "/power_now")) + + -- energy_now(P)[uWh], charge_now(I)[uAh] + local energy_now = tonumber(first_line(bstr .. "/energy_now") or + first_line(bstr .. "/charge_now")) + + -- energy_full(P)[uWh], charge_full(I)[uAh] + local energy_full = tonumber(first_line(bstr .. "/energy_full") or + first_line(bstr .. "/charge_full")) + + local energy_percentage = tonumber(first_line(bstr .. "/capacity")) or + math.floor((energy_now / energy_full) * 100) + + if bat_now.status ~= "Charging" and bat_now.status ~= "Discharging" + then + bat_now.status = first_line(bstr .. "/status") or "N/A" end - local hours = math.floor(rate_time) - local minutes = math.floor((rate_time - hours) * 60) - local watt = rate_power and (rate_power / 1e6) or (rate_voltage * rate_current) / 1e12 - - bat_now.perc = string.format("%d", math.min(100, energy_percentage)) - bat_now.time = string.format("%02d:%02d", hours, minutes) - bat_now.watt = string.format("%.2fW", watt) + sum_rate_current = sum_rate_current + (rate_current or 0) + sum_rate_voltage = sum_rate_voltage + rate_voltage + sum_rate_power = sum_rate_power + (rate_power or ((rate_voltage * rate_current) / 1e6)) + sum_energy_now = sum_energy_now + energy_now + sum_energy_full = sum_energy_full + energy_full + sum_energy_percentage = sum_energy_percentage + energy_percentage end end + local astr = "/sys/class/power_supply/" .. ac + bat_now.ac_status = first_line(astr .. "/online") or "N/A" + + -- update {perc,time,watt} iff rate > 0 and battery not full + if ((sum_rate_current > 0) or (sum_rate_power > 0)) + and bat_now.status ~= "N/A" and bat_now.status ~= "Full" + then + local rate_time = 0 + if bat_now.status == "Charging" then + rate_time = (sum_energy_full - sum_energy_now) / (sum_rate_power or sum_rate_current) + elseif bat_now.status == "Discharging" then + rate_time = sum_energy_now / (sum_rate_power or sum_rate_current) + end + + local hours = math.floor(rate_time) + local minutes = math.floor((rate_time - hours) * 60) + local watt = sum_rate_power / 1e6 + bat_now.perc = string.format("%d", math.min(100, sum_energy_percentage / table.getn(batteries))) + bat_now.time = string.format("%02d:%02d", hours, minutes) + bat_now.watt = string.format("%.2fW", watt) + end + widget = bat.widget settings() From 0802b5a70487c5db66b339a57e75a5b2236beeb7 Mon Sep 17 00:00:00 2001 From: copycat-killer Date: Mon, 30 May 2016 21:01:44 +0200 Subject: [PATCH 2/8] #198: correct logic --- widgets/pulsebar.lua | 10 +++++----- widgets/weather.lua | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/widgets/pulsebar.lua b/widgets/pulsebar.lua index 6955b04..5004be6 100644 --- a/widgets/pulsebar.lua +++ b/widgets/pulsebar.lua @@ -1,10 +1,10 @@ --[[ - - Licensed under GNU General Public License v2 - * (c) 2013, Luke Bonham - * (c) 2013, Rman - + + Licensed under GNU General Public License v2 + * (c) 2013, Luke Bonham + * (c) 2013, Rman + --]] local newtimer = require("lain.helpers").newtimer diff --git a/widgets/weather.lua b/widgets/weather.lua index 7ff498a..75c2342 100644 --- a/widgets/weather.lua +++ b/widgets/weather.lua @@ -126,9 +126,9 @@ local function worker(args) if not err and weather_now and tonumber(weather_now["cod"]) == 200 then -- weather icon based on localtime - now = os.time() - (utc * 3600) - sunrise = tonumber(weather_now["sys"]["sunrise"]) - sunset = tonumber(weather_now["sys"]["sunset"]) + now = os.time() + sunrise = tonumber(weather_now["sys"]["sunrise"]) + (utc * 3600) + sunset = tonumber(weather_now["sys"]["sunset"]) + (utc * 3600) icon = weather_now["weather"][1]["icon"] if sunrise <= now and now <= sunset then From 5efaca89d0c0f44464bd7dbd5b9278b5cf492d86 Mon Sep 17 00:00:00 2001 From: Luke Bonham Date: Tue, 31 May 2016 10:00:28 +0200 Subject: [PATCH 3/8] #198 fix attempt 2 --- widgets/weather.lua | 15 ++++++++++----- wiki | 2 +- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/widgets/weather.lua b/widgets/weather.lua index 75c2342..c8c34f9 100644 --- a/widgets/weather.lua +++ b/widgets/weather.lua @@ -21,7 +21,7 @@ local mouse = mouse local os = { time = os.time } local string = { format = string.format, gsub = string.gsub } - +local naughty = require("naughty") local tonumber = tonumber local setmetatable = setmetatable @@ -126,10 +126,15 @@ local function worker(args) if not err and weather_now and tonumber(weather_now["cod"]) == 200 then -- weather icon based on localtime - now = os.time() - sunrise = tonumber(weather_now["sys"]["sunrise"]) + (utc * 3600) - sunset = tonumber(weather_now["sys"]["sunset"]) + (utc * 3600) - icon = weather_now["weather"][1]["icon"] + local now = os.time() + local sunrise = tonumber(weather_now["sys"]["sunrise"]) + local sunset = tonumber(weather_now["sys"]["sunset"]) + local icon = weather_now["weather"][1]["icon"] + local utc_m = string.gsub(read_pipe(string.format("date -u -d 'today 00:00:00' +'%%s'")), "\n", "") + + if now > tonumber(utc_m) then + now = now - (utc * 3600) + end if sunrise <= now and now <= sunset then icon = string.gsub(icon, "n", "d") diff --git a/wiki b/wiki index fea7079..184b98a 160000 --- a/wiki +++ b/wiki @@ -1 +1 @@ -Subproject commit fea7079ab58cbbea9c18733485f264bc154fe580 +Subproject commit 184b98a8e765fe48f31c30a0ac5d3a3962ed46a1 From 70bee86b8b4e796a7f399f5d795b080ae8f3a4f6 Mon Sep 17 00:00:00 2001 From: Luke Bonham Date: Tue, 31 May 2016 10:44:51 +0200 Subject: [PATCH 4/8] pull #201 fixes --- widgets/bat.lua | 33 ++++++++++++++++++++------------- 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/widgets/bat.lua b/widgets/bat.lua index e1bc5d1..5f049e2 100644 --- a/widgets/bat.lua +++ b/widgets/bat.lua @@ -29,7 +29,7 @@ local function worker(args) local batteries = args.batteries or (args.battery and {args.battery}) or {"BAT0"} local ac = args.ac or "AC0" local notify = args.notify or "on" - local settings = args.settings or function() end + local settings = args.settings or function() end bat.widget = wibox.widget.textbox('') @@ -58,6 +58,11 @@ local function worker(args) watt = "N/A" } + bat_now.n_status = {} + for i = 1, #batteries do + bat_now.n_status[i] = "Not present" + end + local sum_rate_current = 0 local sum_rate_voltage = 0 local sum_rate_power = 0 @@ -87,28 +92,29 @@ local function worker(args) local energy_percentage = tonumber(first_line(bstr .. "/capacity")) or math.floor((energy_now / energy_full) * 100) - if bat_now.status ~= "Charging" and bat_now.status ~= "Discharging" + if bat_now.n_status[i] ~= "Charging" and bat_now.n_status[i] ~= "Discharging" then - bat_now.status = first_line(bstr .. "/status") or "N/A" + bat_now.n_status[i] = first_line(bstr .. "/status") or "N/A" end - sum_rate_current = sum_rate_current + (rate_current or 0) - sum_rate_voltage = sum_rate_voltage + rate_voltage - sum_rate_power = sum_rate_power + (rate_power or ((rate_voltage * rate_current) / 1e6)) - sum_energy_now = sum_energy_now + energy_now - sum_energy_full = sum_energy_full + energy_full + sum_rate_current = sum_rate_current + (rate_current or 0) + sum_rate_voltage = sum_rate_voltage + rate_voltage + sum_rate_power = sum_rate_power + (rate_power or ((rate_voltage * rate_current) / 1e6)) + sum_energy_now = sum_energy_now + energy_now + sum_energy_full = sum_energy_full + energy_full sum_energy_percentage = sum_energy_percentage + energy_percentage end end - local astr = "/sys/class/power_supply/" .. ac - bat_now.ac_status = first_line(astr .. "/online") or "N/A" + bat_now.status = bat_now.n_status[1] + bat_now.ac_status = first_line(string.format("/sys/class/power_supply/%s/online", ac)) or "N/A" -- update {perc,time,watt} iff rate > 0 and battery not full - if ((sum_rate_current > 0) or (sum_rate_power > 0)) - and bat_now.status ~= "N/A" and bat_now.status ~= "Full" + if (sum_rate_current > 0 or sum_rate_power > 0) + and bat_now.status ~= "N/A" and bat_now.status ~= "Full" then local rate_time = 0 + if bat_now.status == "Charging" then rate_time = (sum_energy_full - sum_energy_now) / (sum_rate_power or sum_rate_current) elseif bat_now.status == "Discharging" then @@ -118,7 +124,8 @@ local function worker(args) local hours = math.floor(rate_time) local minutes = math.floor((rate_time - hours) * 60) local watt = sum_rate_power / 1e6 - bat_now.perc = string.format("%d", math.min(100, sum_energy_percentage / table.getn(batteries))) + + bat_now.perc = string.format("%d", math.min(100, sum_energy_percentage / #batteries)) bat_now.time = string.format("%02d:%02d", hours, minutes) bat_now.watt = string.format("%.2fW", watt) end From f67b9d899026312b04d4f7a4263c4214a6cf19d8 Mon Sep 17 00:00:00 2001 From: Luke Bonham Date: Tue, 31 May 2016 10:45:46 +0200 Subject: [PATCH 5/8] wiki updated --- wiki | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wiki b/wiki index 184b98a..9dc477f 160000 --- a/wiki +++ b/wiki @@ -1 +1 @@ -Subproject commit 184b98a8e765fe48f31c30a0ac5d3a3962ed46a1 +Subproject commit 9dc477f6edb5b9c1f28b30fdb6151ae9ce321954 From 84005d16a9c58f385434d3f2e97161ab764b3122 Mon Sep 17 00:00:00 2001 From: Luke Bonham Date: Tue, 31 May 2016 10:55:15 +0200 Subject: [PATCH 6/8] #199 fix attempt --- widgets/bat.lua | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/widgets/bat.lua b/widgets/bat.lua index 5f049e2..6db5d95 100644 --- a/widgets/bat.lua +++ b/widgets/bat.lua @@ -49,20 +49,20 @@ local function worker(args) bg = "#FFFFFF" } + bat_now = { + status = "Not present", + ac_status = "N/A", + perc = "N/A", + time = "N/A", + watt = "N/A" + } + + bat_now.n_status = {} + for i = 1, #batteries do + bat_now.n_status[i] = "Not present" + end + function update() - bat_now = { - status = "Not present", - ac_status = "N/A", - perc = "N/A", - time = "N/A", - watt = "N/A" - } - - bat_now.n_status = {} - for i = 1, #batteries do - bat_now.n_status[i] = "Not present" - end - local sum_rate_current = 0 local sum_rate_voltage = 0 local sum_rate_power = 0 From 1635e0a0ca542229c82ffedfc0d9627117165953 Mon Sep 17 00:00:00 2001 From: copycat-killer Date: Wed, 1 Jun 2016 13:27:53 +0200 Subject: [PATCH 7/8] #198 fix attempt 3 --- widgets/weather.lua | 33 ++++++++++++++++++++++----------- wiki | 2 +- 2 files changed, 23 insertions(+), 12 deletions(-) diff --git a/widgets/weather.lua b/widgets/weather.lua index c8c34f9..b074cff 100644 --- a/widgets/weather.lua +++ b/widgets/weather.lua @@ -16,12 +16,14 @@ local lain_icons = require("lain.helpers").icons_dir local naughty = require("naughty") local wibox = require("wibox") -local math = { floor = math.floor } +local math = { floor = math.floor } +local os = { time = os.time, + date = os.date, + difftime = os.difftime } +local string = { format = string.format, + gsub = string.gsub } + local mouse = mouse -local os = { time = os.time } -local string = { format = string.format, - gsub = string.gsub } -local naughty = require("naughty") local tonumber = tonumber local setmetatable = setmetatable @@ -38,7 +40,11 @@ local function worker(args) local current_call = args.current_call or "curl -s 'http://api.openweathermap.org/data/2.5/weather?id=%s&units=%s&lang=%s&APPID=%s'" local forecast_call = args.forecast_call or "curl -s 'http://api.openweathermap.org/data/2.5/forecast/daily?id=%s&units=%s&lang=%s&cnt=%s&APPID=%s'" local city_id = args.city_id or 0 -- placeholder - local utc = args.utc or 0 + local utc_offset = args.utc_offset or + function () + local now = os.time() + return os.difftime(now, os.time(os.date("!*t", now))) + (os.date("*t").isdst and 3600) + end local units = args.units or "metric" local lang = args.lang or "en" local cnt = args.cnt or 5 @@ -51,7 +57,6 @@ local function worker(args) local tmin = math.floor(wn["temp"]["min"]) local tmax = math.floor(wn["temp"]["max"]) local desc = wn["weather"][1]["description"] - return string.format("%s: %s, %d - %d ", day, desc, tmin, tmax) end local weather_na_markup = args.weather_na_markup or " N/A " @@ -73,7 +78,6 @@ local function worker(args) weather.forecast_update() end - weather.notification = naughty.notify({ text = weather.notification_text, icon = weather.icon_path, @@ -131,9 +135,17 @@ local function worker(args) local sunset = tonumber(weather_now["sys"]["sunset"]) local icon = weather_now["weather"][1]["icon"] local utc_m = string.gsub(read_pipe(string.format("date -u -d 'today 00:00:00' +'%%s'")), "\n", "") + local loc_m = string.gsub(read_pipe(string.format("date -d 'today 00:00:00' +'%%s'")), "\n", "") - if now > tonumber(utc_m) then - now = now - (utc * 3600) + loc_m = tonumber(loc_m) + utc_m = tonumber(utc_m) + offset = utc_offset() + + -- if we are 1 day after the GMT, return 1 day back, and viceversa + if offset > 0 and loc_m >= utc_m then + now = now - 86400 + elseif offset < 0 and loc_m <= utc_m then + now = now + 86400 end if sunrise <= now and now <= sunset then @@ -143,7 +155,6 @@ local function worker(args) end weather.icon_path = icons_path .. icon .. ".png" - widget = weather.widget settings() else diff --git a/wiki b/wiki index 9dc477f..25dd1a2 160000 --- a/wiki +++ b/wiki @@ -1 +1 @@ -Subproject commit 9dc477f6edb5b9c1f28b30fdb6151ae9ce321954 +Subproject commit 25dd1a2ec44da832d06ded29f393d716e4b54783 From 2d8e93f18961e2d5c051b749e667a0ddc9d14ae3 Mon Sep 17 00:00:00 2001 From: copycat-killer Date: Wed, 1 Jun 2016 13:37:20 +0200 Subject: [PATCH 8/8] #199 syntactic change --- widgets/bat.lua | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/widgets/bat.lua b/widgets/bat.lua index 6db5d95..3b9cca0 100644 --- a/widgets/bat.lua +++ b/widgets/bat.lua @@ -110,8 +110,7 @@ local function worker(args) bat_now.ac_status = first_line(string.format("/sys/class/power_supply/%s/online", ac)) or "N/A" -- update {perc,time,watt} iff rate > 0 and battery not full - if (sum_rate_current > 0 or sum_rate_power > 0) - and bat_now.status ~= "N/A" and bat_now.status ~= "Full" + if (sum_rate_current > 0 or sum_rate_power > 0) and not (bat_now.status == "Full") then local rate_time = 0